fix(gateway): fix protocol handling for safari#4865
Conversation
PR Review: fix(gateway): fix protocol handling for safariSummaryThis PR fixes a Findings1. Incomplete data-carrying protocol filtering in the fallback (Low severity)
If In practice, the client always sends // Exclude all data-carrying protocol tokens; only echo plain negotiation identifiers
!protocol.starts_with("rivet_")2. Duplicate
3. No tests added (Minor) Given that the bug is browser-specific and involves protocol ordering behavior, a unit test for
What's correct
SummaryThe fix is sound and directly addresses the Safari compatibility issue. The main concern worth a follow-up is the incomplete filtering of data-carrying protocol prefixes ( |
Preview packages published to npmInstall with: npm install rivetkit@pr-4865All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-b488635
docker pull rivetdev/engine:full-b488635Individual packagesnpm install rivetkit@pr-4865
npm install @rivetkit/react@pr-4865
npm install @rivetkit/rivetkit-napi@pr-4865
npm install @rivetkit/workflow-engine@pr-4865 |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: